Fix unit and integration test flakes #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
approved these changes
Feb 23, 2024
jharveyb
approved these changes
Feb 23, 2024
This commit is a small optimization in that we only start watching for a proof on startup if we did receive a confirmation for it.
This fixes a unit test race condition where two goroutines would be operating on the same proof because they both received the same reference from the mock. This would not happen in production as the proof archive always creates a new proof object. So we fix the race by also creating a unique copy of the mocked proof whenever it is requested.
Fixes #808. This fixes an issue with errors not being wrapped correctly in some places. That lead to the error not being recognized as a Postgres serialization error, which meant the re-try mechanism wouldn't take over.
Fixes #807. If we're syncing a node to a universe that is still in the process of getting proofs pushed to, we sometimes receive leaves with a root that doesn't match the root we fetched at the beginning of the sync process. We should re-try the sync, which we'll do in a separate PR. For now we just want to fix the flake, which we can do by waiting to start a new node until the existing one has finished syncing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #808.
Fixes #810.