tapdb: fix migration 15 #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assumed nobody would have multiple witness entries at this point, as they could only be produced when using the vPSBT API. But a user reported problems when running the migration 15 which indicates they indeed had multiple witnesses per asset (possibly due to multiple imports of the same proof which would be a whole separate issue and likely needs to be fixed in their DB manually). This commit makes sure we insert a non-duplicate default value (we just pick the witness ID as we just care about the order not the actual value).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assumed nobody would have multiple witness entries at this point, as they could only be produced when using the vPSBT API. But a user reported problems when running the migration 15 which indicates they indeed had multiple witnesses per asset (possibly due to multiple imports of the same proof which would be a whole separate issue and likely needs to be fixed in their DB manually).
This commit makes sure we insert a non-duplicate default value (we just pick the witness ID as we just care about the order not the actual value).