Refactor fed envy event handling #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
force-pushed
the
refactor-fed-envy-event-handling
branch
from
8cad828 to
291240a
Compare
ffranr
force-pushed
the
refactor-fed-envy-event-handling
branch
from
291240a to
a107752
Compare
GeorgeTsagk
approved these changes
Dec 12, 2023
guggero
approved these changes
Dec 12, 2023
This commit extracts a tick handler method from the federation envoy event handler routine. The goal of this commit is code simplification and to gain some line length breathing room.
This commit extracts a push request handler method from the federation envoy event handler routine. The goal of this commit is code simplification and to gain some line length breathing room.
This commit extracts a batch push request handler method from the federation envoy event handler routine. The goal of this commit is code simplification and to gain some line length breathing room.
ffranr
force-pushed
the
refactor-fed-envy-event-handling
branch
from
a107752 to
52ac13f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the federation envoy event handling routine with the goal of code simplification and to gain some line length breathing room.
This PR shouldn't change any "business logic".