Fix universe sync test #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstadulis
reviewed
Jun 16, 2023
| @@ -728,7 +728,7 @@ func assertUniverseStateEqual(t *testing.T, a, b *tapdHarness) { | |||
| rootsA, err := a.AssetRoots(ctxb, &unirpc.AssetRootRequest{}) | |||
| require.NoError(t, err) | |||
|
|
|||
| rootsB, err := a.AssetRoots(ctxb, &unirpc.AssetRootRequest{}) | |||
Roasbeef
approved these changes
Jun 16, 2023
| func assertUniverseStateEqual(t *testing.T, a, b *tapdHarness) { | ||
| ctxb := context.Background() | ||
|
|
||
| rootsA, err := a.AssetRoots(ctxb, &unirpc.AssetRootRequest{}) | ||
| require.NoError(t, err) | ||
|
|
||
| rootsB, err := a.AssetRoots(ctxb, &unirpc.AssetRootRequest{}) | ||
| rootsB, err := b.AssetRoots(ctxb, &unirpc.AssetRootRequest{}) |
|
|
||
| t.Helper() | ||
|
|
||
| require.Eventually(t, func() bool { |
There was a problem hiding this comment.
Ahh, this super useful!
Otherwise you need to modify things to return an error for the usual wait instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while trying to reproduce a different error.
Looks like we didn't really compare the correct universe roots in the integration tests.