Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof: add code for stitching together failed proof suffixes #1188

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Nov 12, 2024

This helped me verify and fix proofs in #1168 and I think the code might be useful for other things too. It won't run in CI, so no harm in keeping it IMO.

@coveralls
Copy link

coveralls commented Nov 12, 2024

Pull Request Test Coverage Report for Build 11804110858

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.005%) to 40.609%

Files with Coverage Reduction New Missed Lines %
internal/test/helpers.go 2 86.85%
tappsbt/create.go 2 53.22%
tapgarden/planter.go 2 74.87%
tapchannel/aux_leaf_signer.go 3 36.33%
commitment/tap.go 4 84.17%
universe/interface.go 15 47.09%
Totals Coverage Status
Change from base Build 11789807486: -0.005%
Covered Lines: 24682
Relevant Lines: 60779

💛 - Coveralls

@guggero
Copy link
Member Author

guggero commented Nov 18, 2024

Merging, as this is just a test that's skipped by default anyway.

@guggero guggero merged commit 47a265d into main Nov 18, 2024
18 checks passed
@guggero guggero deleted the proof-stitching branch November 18, 2024 16:22
gijswijs pushed a commit that referenced this pull request Nov 20, 2024
proof: add code for stitching together failed proof suffixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants