[universe]: fix proof sync for large asset minting batches #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10470347293Details
💛 - Coveralls |
jharveyb
reviewed
Aug 19, 2024
This commit fixes an issue with large sets of asset issuances: When there are more assets in a group than the current batch sync limit (200), then there's a chance that the group anchor (the one asset containing the group key reveal record) isn't in the first batch. So we wouldn't be able to insert the first batch at all, since those assets would all reference a group key that isn't yet known. To avoid this problem, we insert any proofs with group key reveal records immediately and only start batching the others after going through all of them. This means we'll keep more assets in memory and can start to process them later. But at least the process won't fail anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this on
testnetwhile trying to reproduce #675.Can be reproduced with:
And
tapcli u s --universe_host testnet.universe.lightning.finance:10029.This PR fixes the issue by making sure any group anchors are inserted into the DB first.