Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: copy over Go version check scripts from LND #1080

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Aug 13, 2024

Replaced the existing Go version check scripts with those from the LND repository. These updated scripts are confirmed to work on macOS. The commit also relocates the scripts to the scripts directory from the tools directory.

The goal is to have the same scripts in both repositories.

Replaced the existing Go version check scripts with those from the LND
repository. These updated scripts are confirmed to work on macOS. The
commit also relocates the scripts to the `scripts` directory from the
`tools` directory.
@ffranr ffranr requested review from guggero and GeorgeTsagk August 13, 2024 12:29
@ffranr ffranr self-assigned this Aug 13, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10369749239

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 53 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.06%) to 40.159%

Files with Coverage Reduction New Missed Lines %
tapgarden/planter.go 2 74.87%
asset/asset.go 2 81.73%
internal/test/helpers.go 3 85.75%
tapdb/universe.go 4 80.91%
commitment/tap.go 5 83.64%
tapgarden/caretaker.go 11 68.21%
tapdb/multiverse.go 11 59.83%
universe/interface.go 15 47.09%
Totals Coverage Status
Change from base Build 10354280528: -0.06%
Covered Lines: 23657
Relevant Lines: 58908

💛 - Coveralls

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@ffranr ffranr requested review from jharveyb and removed request for GeorgeTsagk August 16, 2024 10:20
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ffranr ffranr added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit e3c8d02 Aug 16, 2024
17 checks passed
@guggero guggero deleted the go-version-scripts-lnd branch August 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants