rfq: actually set subject asset in QueryRateTick #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10364983236Details
💛 - Coveralls |
dstadulis
reviewed
Aug 12, 2024
ffranr
approved these changes
Aug 12, 2024
Fixes the problem that because of the missing allocation, the subject asset ID was always set to an empty slice.
guggero
force-pushed
the
rfq-fix-asset-id
branch
from
0edbd88 to
c369d6a
Compare
jharveyb
approved these changes
Aug 13, 2024
| paymentAssetId := make([]byte, 32) | ||
| // The payment asset ID is BTC, so we leave it at all zeroes. We only | ||
| // set the subject asset ID. | ||
| copy(subjectAssetId, assetId[:]) |
There was a problem hiding this comment.
super-nit: could be fn.CopySlice(assetId[:]).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem that because of the missing allocation, the subject asset ID was always set to an empty slice.
Reported by Luke in Slack, thanks a lot for pointing out the problem!