taprpc: marshal with metareveal of issuance proof #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
proof_decode_read_metareveal
branch
2 times, most recently
from
ab1d49f to
e7bc705
Compare
If the meta data isn't JSON when we expect it to be, we return the correct error.
When attempting to fetch the decimal display in a non strict way, we directly return fn.None() if the meta data isn't valid JSON.
guggero
force-pushed
the
proof_decode_read_metareveal
branch
from
e7bc705 to
21c1148
Compare
|
Was able to reproduce and continued on the fix. Should be all good now. |
guggero
approved these changes
Jul 25, 2024
ffranr
reviewed
Jul 25, 2024
rpcserver.go
Outdated
| // getDecimalDisplayNonStrict attempts to decode a decimal display value from | ||
| // metadata. If no custom decimal display value is decoded, the default value of | ||
| // 0 is returned without error. | ||
| func getDecimalDisplayNonStrict(meta *proof.MetaReveal) (uint32, error) { |
There was a problem hiding this comment.
I think this should return an fn.Option instead of defaulting to 0. Later at the callsite, taprpc.MarshalAsset takes an option anyway.
There was a problem hiding this comment.
That's added in a later commit. Perhaps you were looking at an outdated version?
There was a problem hiding this comment.
I don't think I was looking at an outdated version of the commit set. I was going through each commit in order. I think later commits change the changes of earlier commits.
ffranr
approved these changes
Jul 25, 2024
|
lgtm 🎉 |
gijswijs
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes decoding of issuance proofs from other nodes.
An example issuance proof:
Decode to binary by piping to
xxd -r -p. If we try to decode withtapcli proofs decode, we get an error about a metadata lookup failure for this asset.This fixes that by reading the metadata from the metareveal of the proof if present.