Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof: relax parsing in DecDisplayForAssetID #1002

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

Roasbeef
Copy link
Member

If an old asset didn't have this field, then we can just assume that the value is zero, rather than error out.

Fixes #1001

@jharveyb
Copy link
Contributor

That return was used to enter this case:

case errors.Is(err, ErrDecDisplayMissing),

Which would trigger adding the display to the JSON. So that should get updated as well.

@Roasbeef Roasbeef force-pushed the fix-decimal-precision branch from c952e6d to ee817e7 Compare July 10, 2024 03:55
@Roasbeef Roasbeef changed the title proof: relax parsing in GetDecDisplay proof: relax parsing in DecDisplayForAssetID Jul 10, 2024
@Roasbeef Roasbeef force-pushed the fix-decimal-precision branch from ee817e7 to 81d90cc Compare July 10, 2024 04:02
If an old asset didn't have this field, then we can just assume that the
value is zero, rather than error out.

Fixes #1001
@Roasbeef Roasbeef force-pushed the fix-decimal-precision branch from 81d90cc to 4491aff Compare July 10, 2024 04:03
@jharveyb jharveyb self-requested a review July 10, 2024 04:28
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏽

@Roasbeef Roasbeef merged commit 5e1529c into main Jul 10, 2024
16 checks passed
@guggero guggero deleted the fix-decimal-precision branch November 25, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants