set headerfs.BlockStamp.Timestamp #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
commented
Nov 11, 2021
chappjc
commented
Nov 11, 2021
chappjc
force-pushed
the
timestamp-blockstamp
branch
from
6cad667
to
69a978c
Compare
|
@chappjc, remember to re-request review from reviewers for your latest update |
|
@ellemouton: review reminder |
The headerfs.BlockStamp returned from (*ChainService).BestBlock had a zero Timestamp. This change sets the Timestamp field from the block header.
chappjc
force-pushed
the
timestamp-blockstamp
branch
from
69a978c
to
88c025e
Compare
|
🙏 Thanks! This will be a helpful change on our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
headerfs.BlockStampreturned from(*ChainService).BestBlockhad a zeroTimestamp.This change sets the
Timestampfield from the block header if available.Internally it does not seem to matter that
Timestampis the zerotime.Time, but forChainServiceconsumers it is helpful to have the block's timestamp. For example, one may compare the timestamp from the current best block fromChainServiceto the walletManager's birthday time.