makefile: add unit test helpers #928
Conversation
Add a new COMPILE_TAGS environment variable that includes all the basic set of tags that lit requires in order for compilation to succeed. Let LND_RELEASE_TAGS then extend these flags. This will let us expand the testing_flags.mk file later without needing to use the LND_RELEASE_TAGS variable there.
And use the new COMPILE_TAGS variable for the unit commands instead of LND_RELEASE_TAGS.
ellemouton
force-pushed
the
makeUnitTestHelpers
branch
from
574ddc8 to
0f6b014
Compare
ellemouton
force-pushed
the
makeUnitTestHelpers
branch
2 times, most recently
from
a088437 to
4def4d2
Compare
This commit let's us specify commands of the form: `make unit case=TestNameHere`. Note that this commit by itself is not very useful in LiT since there are no tests in the main `terminal` package. A later commit will let us set a package name too and then this will be more useful.
This commit lets us perform commands of the form: `make unit tags=postgres` to add additional tags to the command. This will be useful in a future where we, for example, want to run unit tests against a specific DB backend.
This commit lets us perform make commands of the following form: `make unit pkg=accounts` which will run all the tests in the specified package. Or you can do `make unit pkg=accounts case=TestAccountStore` to run a specific test in the specified package.
Later on we will want to run the unit tests against different backends. When that is the case, we can just add a new unit_type to this matrix instead of needing to repeat all the same set-up steps.
ellemouton
force-pushed
the
makeUnitTestHelpers
branch
from
4def4d2 to
d6f184c
Compare
| # If a specific package/test case was requested, run the unit test for the | ||
| # targeted case. Otherwise, default to running all tests. | ||
| ifeq ($(UNIT_TARGETED), yes) | ||
| UNIT := $(GOTEST) -tags="$(DEV_TAGS) $(COMPILE_TAGS)" $(TEST_FLAGS) $(UNITPKG) |
There was a problem hiding this comment.
make unit case=TestObfuscateConfig would not run, but only adding the package will add the test files in order for the test to be discoverable: make unit case=TestObfuscateConfig pkg=firewall. Do we want that, because it seems like an extra step that we could avoid?
There was a problem hiding this comment.
note that this was mentioned in this commit message: 824a3c2
There was a problem hiding this comment.
you have to specify package. Otherwise you have to search through all packages. Im sure there is a helper we can add later on but think this is fine for now?
There was a problem hiding this comment.
note that this was mentioned in this commit message: 824a3c2
ah yes, now that makes sense! I just noticed that in lnd it's the same (usually I'm running tests differently), so it makes sense to keep things consistent across projects. it really takes a lot longer if we'd include all packages with 24s vs 2s 👍
Some helpers (lots of influence from the
taproot-assetsrepo) to give devs more control over running unit tests.With this, we can now do things like: