dev.Dockerfile: allow forcing a specific taproot-assets version #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Dec 6, 2024
dev.Dockerfile
Outdated
| @@ -23,10 +23,18 @@ COPY --from=nodejsbuilder /go/src/github.com/lightninglabs/lightning-terminal /g | |||
| # queries required to connect to linked containers succeed. | |||
| ENV GODEBUG netdns=cgo | |||
|
|
|||
| # allow forcing a specific taproot-assets version through a build argument | |||
There was a problem hiding this comment.
nit: we use complete sentences including proper capitalization and punctuation for all comments in all our projects. And where possible (depending on the file format and content), we try to adhere to the 80 character limit outside of Go code as well.
guggero
force-pushed
the
update-to-lnd-18-4
branch
4 times, most recently
from
dd49654 to
890764a
Compare
added 2 commits
December 11, 2024 12:47
ZZiigguurraatt
force-pushed
the
taproot-assets-build-arg
branch
from
2db47f9 to
e192d1e
Compare
guggero
merged commit 1f4a0cd
into
lightninglabs:update-to-lnd-18-4
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev.Dockerfile: allow forcing a specific taproot-assets version through a build argument.
An example of usage can be found here: https://github.com/lightninglabs/tapdvalidation/blob/cb7c752e9b123dc99882a471afa04cc1066e5111/docker-compose.yaml#L66