Revert "make: update VERSION_TAG to a globally-consistent build-input identifier" #880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit
66d2bd1bdade3cacf1df263799bf4569a97af3ec
. Unfortunately, this commit leads to a-dirty
suffix being added to built releases, on multiple environments. The reason for that is that as themake release
build process rebuilds the app build folder, which temporarily removes the.gitkeep
file in that folder. As theVERSION_TAG
then gets based on a build that lacks the.gitkeep
file, the build process adds the-dirty
suffix to the version.To reviewers:
I'm pushing this as a draft PR for now, as I'd like to get a approach ACK that we'd like to do revert the commit.
Alternatively to reverting, the only other approach I could figure that actually worked to consistently produce a release build without the
-dirty
suffix, is to simply remove the execution ofapp-build
in themake release
command. We'd then need to make it a prerequisite to execute themake app-build
command prior to themake release
command during the release process. As that's not very bullet proof and easy to forget, I wouldn't personally opt for doing so. As our actual releases does come with a-dirty
suffix for the commit when runninglitd --version
, I could also see the argument for actually doing releases in that way.This alternative approach could potentially also make it easier to achieve actual consistent reproducible releases across different environments as well.