lightning-terminal: ensure reproducible releases #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update modifies the release.sh script to ensure that release files are reproducible, generating identical hashes when rebuilt. Previously, the script did not set fixed timestamps for the files, resulting in different hashes across rebuilds. Additionally, the release.sh script has been updated to align more closely with the behavior of the lnd release script, ensuring consistency and coherence across repositories for users.
Comment on lines
+155
to
+158
| # Add the hash of the packages too, then sort by the second column (name). | ||
| shasum -a 256 lightning-terminal-* vendor* >> "manifest-$tag.txt" | ||
| LC_ALL=C sort -k2 -o "manifest-$tag.txt" "manifest-$tag.txt" | ||
| cat "manifest-$tag.txt" |
There was a problem hiding this comment.
Let me know if you think this is unnecessary for litd, but I figured we'd probably want to mimic the lnd behaviour as much as possible to be as coherent between the repos as possible.
ViktorTigerstrom
force-pushed
the
2024-09-reproducible-releases
branch
from
519599a to
1de02f7
Compare
|
@dstadulis: review reminder |
|
Replaced by #881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update modifies the release.sh script to ensure that release files are reproducible, generating identical hashes when rebuilt. Previously, the script did not set fixed timestamps for the files, resulting in different hashes across rebuilds.
Additionally, the release.sh script has been updated to align more closely with the behavior of the lnd release script, ensuring consistency and coherence across repositories for users. Let me know if you think it's unnecessary for us to mimic those behaviour in
litd:)