multi: add DisableUI option #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
disableui
branch
5 times, most recently
from
719b306 to
f9aa1c4
Compare
guggero
reviewed
Mar 17, 2023
In this commit, a new Proxy service is added with a StopDaemon method. This method can be used to stop the Litd service. This will be useful in remote-mode itests where we want to restart Litd without also restarting LND. It also provides a nice way of shutting down Litd in remote-mode. A GetInfo method is also added to the service which for now just returns the Litd version. The reason for adding this method now is so that access to the new Proxy service can be tested in the itests withouth actually shutting down Litd.
Let the itest framework make use of the new StopDaemon method. When instructed to Stop the node, if it is running in remote mode then only the litd node itself should be stopped and not the remote LND node.
Add a new `disableui` config option. If this option is set then the user no longer needs to set the `uipassword` config option. This also means that the user will no longer be able to interact with the local UI.
Add new `WithoutLitArg` and `WithLitArg` functional options that can be passed to `GenArgs` when a node is being restarted. This makes it easy to change the arguments of a node on restart.
ellemouton
commented
Mar 17, 2023
There was a problem hiding this comment.
Thanks for the speedy review @guggero! Added the GetInfo method 👍
jamaljsr
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this option set, the local UI will not be served and so the UI password does not need to be set.
To make use of this, you can remove the
--uipassword=from your config file (or command line argument)And can instead add
--disableui.To test, start up Litd with the above options and see that navigating to "localhost:8448" now returns a 401.
Also adds new commands to litcli:
Fixes: #448