Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: add darwin-arm64 to release build architectures #507

Merged
merged 1 commit into from
Feb 27, 2023
Merged

make: add darwin-arm64 to release build architectures #507

merged 1 commit into from
Feb 27, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Feb 27, 2023

Fixes #491.

jamaljsr
jamaljsr approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

I was able to build and run this on my M1 Mac with no issues.

ellemouton
ellemouton approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guggero guggero merged commit 5052d72 into master Feb 27, 2023
@guggero guggero deleted the mac-os-arm branch February 27, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellemouton ellemouton ellemouton approved these changes

@jamaljsr jamaljsr jamaljsr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing darwin arm build
3 participants
@guggero @jamaljsr @ellemouton