Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: add RevokedAt field to Session #475

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

ellemouton
Copy link
Member

In this PR, a new RevokedAt field is added to the Session struct and it is set to the current time when RevokeSession is called. Note that since it is a new field, old sessions will have a zero value RevokedAt time and so readers of a session should still use the sesssion's Status field to determine if a session is revoked or not.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🎉

session/tlv.go Outdated Show resolved Hide resolved
session_rpcserver.go Outdated Show resolved Hide resolved
This commit adds a RevokedAt field to the Session structure and sets the
value of the field to the current time when RevokeSession is called.
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellemouton ellemouton merged commit 0653424 into lightninglabs:master Jan 10, 2023
@ellemouton ellemouton deleted the storeRevokedAt branch January 10, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants