Custom user permissions UI #451

itsrachelfish · 2022-11-04T22:01:41Z

This PR updates the Lightning Node Connect page to include a new overlay which allows users to create macaroons with customized permissions for specific URIs as well as expiration dates.

New option added to permissions dropdown

Custom permissions overlay

Custom session with an expiration date

Related to: #438
Depends on #450 & #457

- Grid container - Date picker input - Full page overlay form - Text helpers

jbrill · 2022-11-22T19:53:35Z

One future thing that could be helpful is to create a common component library as a node package for us to consume in both terminal and lit. This way we could avoid duplicated code, and maybe create a storybook for @dstrukt to view what's being used in the codebase

app/src/components/common/v2/Text.tsx

jbrill · 2022-11-22T20:07:34Z

Should Liquidity Manager and Payments Manager permission roles be in the dropdown as well?

levmi · 2022-11-22T20:08:44Z

Should Liquidity Manager and Payments Manager permission roles be in the dropdown as well?

Design/product decision to just have those live in custom as well. Want to see if people use them or not. Will populate the dropdown with the most popular options based on feedback. Still unsure how popular those two will be, but it's our first stab at it.

jbrill · 2022-11-22T20:08:45Z

I can imagine the terminal lift will be significant for some of these custom permissions -- would those changes happen before the merge? Just curious

jbrill · 2022-11-22T20:10:31Z

The code looks very clean and can confirm the feature works very well 👍

Will do a more thorough pass when it's ready for review!

dstrukt · 2022-11-22T20:12:36Z

Initial run through looks great @itsrachelfish awesome work .. could definitely be code-reviewed at this stage!

Will type up more notes and nits.

app/src/components/common/FormDate.tsx

app/src/components/common/v2/FormSwitch.tsx

app/src/components/connect/CustomSessionPage.tsx

dstrukt · 2022-11-23T03:05:24Z

One future thing that could be helpful is to create a common component library as a node package for us to consume in both terminal and lit. This way we could avoid duplicated code, and maybe create a storybook for @dstrukt to view what's being used in the codebase

This is interesting .. ACK for the shared library, and storybook if we keep it low effort for time being.

app/src/store/views/addSessionView.ts

dstrukt · 2022-11-28T20:46:04Z

Design Review:

Add 24px padding above Proxy Server input

Make the calendar icon our offWhite

Make the calendar text copy click trigger the dropdown, only the icon does this (ideal, but not required)
Conversely, the icon click on the select dropdown should trigger the dropdown too .. but this is an issue across LITD/TW, so another ideal, but not required, and might be worth a sep. issue, but defer to you
Add a 200ms ease-in-out transition to the background-color when hovering/selecting a Permission Type (just a nice to have)

dstrukt

See above.

itsrachelfish · 2022-12-01T13:21:04Z

@dstrukt The calendar icon for the date picker is added automatically by chrome, and the click behavior is controlled by the browser as well. When you test in firefox there is no date picker icon and the entire input field is clickable. I was able to change the color of the date picker icon but not much else

jamaljsr

tACK 🔥 Tested many different permission configurations and didn't run into any issues.

Overall, the code looks great. I commented with a bunch of nits which aren't blocking this from being merged. Just some minor improvements to make it easy to grasp what's happening in the code.

app/src/store/views/addSessionView.ts

app/src/components/connect/CustomSessionPage.tsx

dstrukt

Changes LGTM!

Excellent work!

dstrukt · 2022-12-06T00:36:33Z

Only other thing I noticed .. shouldn't we generate a generic label "My Custom Session" or whatever?

Or am I missing something?

cc @levmi @itsrachelfish

…ded for different permission levels

itsrachelfish · 2022-12-12T08:47:24Z

@dstrukt I added some code to automatically generate labels when none are defined. Users can still specify their own label when first viewing the add session option. However if no label is specified, the custom permissions page will automatically generate a label based on the permission type selected.

"My read-only session", "My liquidity session", "My loop session", etc.

jamaljsr · 2022-12-12T19:23:08Z

Thanks for the updates. The latest commit LGTM 🚀

levmi

All LGTM, great work!

ellemouton · 2023-01-11T18:16:06Z

needs a rebase :)

itsrachelfish · 2023-01-12T00:45:53Z

@levmi @ellemouton updated with the latest from master 👍

ellemouton

tACK 🔥

guggero · 2023-01-13T16:15:19Z

@itsrachelfish do you want to rebase to get a clean commit history (all authored and committed by you) or should we just merge?

lightninglabs-deploy · 2023-01-20T17:15:06Z

@itsrachelfish, remember to re-request review from reviewers when ready

dstrukt self-requested a review November 4, 2022 23:04

itsrachelfish added 4 commits November 4, 2022 23:41

deps: Installed rc-switch and terminal-web FormSwitch component

ae43df0

deps: Installed react-collapse

084f0a2

ui+common: Added components from terminal-web

3c63b20

- Grid container - Date picker input - Full page overlay form - Text helpers

ui+connect: Custom permissions page

4665cf3

itsrachelfish force-pushed the custom-connect-ui branch from 88f136d to 396235b Compare November 22, 2022 08:51

levmi assigned itsrachelfish Nov 22, 2022

levmi added enhancement New feature or request config labels Nov 22, 2022

jbrill reviewed Nov 22, 2022

View reviewed changes

app/src/components/common/v2/Text.tsx Show resolved Hide resolved

app/src/components/common/v2/Text.tsx Show resolved Hide resolved

jbrill reviewed Nov 22, 2022

View reviewed changes

app/src/components/common/FormDate.tsx Show resolved Hide resolved

jbrill reviewed Nov 22, 2022

View reviewed changes

app/src/components/common/v2/FormSwitch.tsx Show resolved Hide resolved

jbrill reviewed Nov 22, 2022

View reviewed changes

app/src/components/connect/CustomSessionPage.tsx Outdated Show resolved Hide resolved

itsrachelfish force-pushed the custom-connect-ui branch 2 times, most recently from 37c5229 to 8629c38 Compare November 28, 2022 09:46

itsrachelfish changed the title ~~WIP - Custom user permissions UI~~ Custom user permissions UI Nov 28, 2022

itsrachelfish force-pushed the custom-connect-ui branch from 8629c38 to 85ce006 Compare November 28, 2022 09:56

itsrachelfish marked this pull request as ready for review November 28, 2022 09:56

ellemouton requested changes Nov 28, 2022

View reviewed changes

app/src/store/views/addSessionView.ts Outdated Show resolved Hide resolved

itsrachelfish force-pushed the custom-connect-ui branch from 85ce006 to 1d8faef Compare November 28, 2022 18:45

dstrukt requested changes Nov 28, 2022

View reviewed changes

itsrachelfish requested a review from jamaljsr December 1, 2022 14:20

itsrachelfish force-pushed the custom-connect-ui branch 2 times, most recently from 1b5bb29 to 54dc1f3 Compare December 1, 2022 22:24

jamaljsr approved these changes Dec 2, 2022

View reviewed changes

dstrukt self-requested a review December 2, 2022 19:18

dstrukt approved these changes Dec 6, 2022

View reviewed changes

itsrachelfish added 2 commits December 12, 2022 01:36

util+constants: PermissionUriMap for tracking which endpoints are nee…

45613bb

…ded for different permission levels

mobx: Created addSessionView, added support for custom sessions

c3b1ba1

itsrachelfish force-pushed the custom-connect-ui branch 2 times, most recently from f40bcc4 to c87fd62 Compare December 12, 2022 09:22

levmi approved these changes Dec 14, 2022

View reviewed changes

ui+connect: Custodial account support

3bc24b5

itsrachelfish mentioned this pull request Jan 4, 2023

Custodial account UI #471

Merged

itsrachelfish added 2 commits January 6, 2023 13:24

api+lit: Updated litapi to include new account RPC

f470c13

mobx: Updated addSessionView to support custodial accounts

95c1ebd

itsrachelfish force-pushed the custom-connect-ui branch from c87fd62 to e64c2e3 Compare January 6, 2023 20:51

levmi requested a review from ellemouton January 11, 2023 18:11

itsrachelfish force-pushed the custom-connect-ui branch 2 times, most recently from 863f5b0 to 4665cf3 Compare January 12, 2023 00:36

ellemouton approved these changes Jan 12, 2023

View reviewed changes

itsrachelfish force-pushed the custom-connect-ui branch from 797689c to 3bc24b5 Compare January 14, 2023 09:09

guggero merged commit 3b58e8e into master Jan 20, 2023

guggero deleted the custom-connect-ui branch January 20, 2023 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom user permissions UI #451

Custom user permissions UI #451

itsrachelfish commented Nov 4, 2022 •

edited

Loading

jbrill commented Nov 22, 2022

jbrill commented Nov 22, 2022

levmi commented Nov 22, 2022

jbrill commented Nov 22, 2022

jbrill commented Nov 22, 2022

dstrukt commented Nov 22, 2022 •

edited

Loading

dstrukt commented Nov 23, 2022 •

edited

Loading

dstrukt commented Nov 28, 2022 •

edited by itsrachelfish

Loading

dstrukt left a comment

itsrachelfish commented Dec 1, 2022

jamaljsr left a comment

dstrukt left a comment •

edited

Loading

dstrukt commented Dec 6, 2022 •

edited

Loading

itsrachelfish commented Dec 12, 2022

jamaljsr commented Dec 12, 2022

levmi left a comment

ellemouton commented Jan 11, 2023

itsrachelfish commented Jan 12, 2023

ellemouton left a comment

guggero commented Jan 13, 2023

lightninglabs-deploy commented Jan 20, 2023

Custom user permissions UI #451

Custom user permissions UI #451

Conversation

itsrachelfish commented Nov 4, 2022 • edited Loading

New option added to permissions dropdown

Custom permissions overlay

Custom session with an expiration date

jbrill commented Nov 22, 2022

jbrill commented Nov 22, 2022

levmi commented Nov 22, 2022

jbrill commented Nov 22, 2022

jbrill commented Nov 22, 2022

dstrukt commented Nov 22, 2022 • edited Loading

dstrukt commented Nov 23, 2022 • edited Loading

dstrukt commented Nov 28, 2022 • edited by itsrachelfish Loading

dstrukt left a comment

Choose a reason for hiding this comment

itsrachelfish commented Dec 1, 2022

jamaljsr left a comment

Choose a reason for hiding this comment

dstrukt left a comment • edited Loading

Choose a reason for hiding this comment

dstrukt commented Dec 6, 2022 • edited Loading

itsrachelfish commented Dec 12, 2022

jamaljsr commented Dec 12, 2022

levmi left a comment

Choose a reason for hiding this comment

ellemouton commented Jan 11, 2023

itsrachelfish commented Jan 12, 2023

ellemouton left a comment

Choose a reason for hiding this comment

guggero commented Jan 13, 2023

lightninglabs-deploy commented Jan 20, 2023

itsrachelfish commented Nov 4, 2022 •

edited

Loading

dstrukt commented Nov 22, 2022 •

edited

Loading

dstrukt commented Nov 23, 2022 •

edited

Loading

dstrukt commented Nov 28, 2022 •

edited by itsrachelfish

Loading

dstrukt left a comment •

edited

Loading

dstrukt commented Dec 6, 2022 •

edited

Loading