subserver_perms: add Lnd's registered subserver perms #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
addLndSubserverPerms
branch
from
a574294 to
f31e7cc
Compare
ellemouton
force-pushed
the
addLndSubserverPerms
branch
from
f31e7cc to
4007c79
Compare
jamaljsr
previously approved these changes
Aug 30, 2022
ellemouton
commented
Aug 30, 2022
guggero
reviewed
Aug 30, 2022
ellemouton
force-pushed
the
addLndSubserverPerms
branch
3 times, most recently
from
5f74bbc to
37a657f
Compare
|
Thank you for the quick review on this @jamaljsr & @guggero 🙏 @guggero: You are completely right - it was definitely getting a bit hard to follow the code. I have taken your suggestion and added a Did it slightly different to how you suggested so let me know if you think this way is fine. |
ellemouton
force-pushed
the
addLndSubserverPerms
branch
from
37a657f to
9e981e6
Compare
guggero
reviewed
Sep 1, 2022
In this commit, a new PermissionsManager is added. It handles all the active permissions that Lit has access to. This moves us away from using global variables for permission lists. This change might seem overkill on its own but hugely simplifies the permission management once we add lnd subserver permissions.
ellemouton
force-pushed
the
addLndSubserverPerms
branch
from
9e981e6 to
78812ca
Compare
guggero
reviewed
Sep 1, 2022
ellemouton
force-pushed
the
addLndSubserverPerms
branch
from
78812ca to
4463324
Compare
In this commit, we let the PermissionsManager manage LND's subserver permissions. Once Litd is connected to LND, it can get LND's build tags and pass them to the PermissionsManager which will then adjust its list of permissions accordingly.
ellemouton
force-pushed
the
addLndSubserverPerms
branch
from
4463324 to
b3ad811
Compare
jamaljsr
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we include all LND's rpc subserver permissions in the permission list used to create the macaroons used in Litd (for sessions etc). The way this is done is a temporary solution while we wait for an LND change that exports the permissions required by each subserver.
Fixes lightninglabs/lnc-web#60
Run alongside lightninglabs/lightning-node-connect#55 to test