Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update npm dependencies #396

Merged
merged 3 commits into from
Aug 3, 2022
Merged

chore: update npm dependencies #396

merged 3 commits into from
Aug 3, 2022

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Aug 3, 2022

This PR updates the React and Storybook dependencies.

It also adds a dependabot.yml config file to instruct it to ignore security issues for packages listed under devDependencies. The PRs #385 and #393 that dependabot created are for for child dependencies of Storybook. After updating the @storybook/* packages to the latest version, the vulnerable versions of those packages are still included. However, that code is never bundled in the production app build and therefore does not pose an actual security risk. They can be safely ignored.

@jamaljsr jamaljsr requested a review from guggero August 3, 2022 02:13
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jamaljsr jamaljsr merged commit c092b7e into master Aug 3, 2022
@jamaljsr jamaljsr deleted the update-deps branch August 3, 2022 15:59
jamaljsr added a commit that referenced this pull request Aug 3, 2022
It turns out that the `dependabot.yml` config file only applies to *version* updates, not *security* updates. When I added this file in #396, the bot decided to open PRs for some of our production dependencies, even if there isn't a security issue with those packages. I don't like the automated PRs because it turns into a bunch of spam in the repo. I'm deleting this file to turn off the dependabot version updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants