frdrpc: add POST bindings for more complex calls #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using GET mappings for REST means we have to place every parameter in the URL query. This is not very convenient if there are many parameters. But even worse, some types like arrays/slices aren't supported in query parameters and map types are very awkward to use. So we add POST mappings for the calls that have many or more complex request parameters.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163.
Using GET mappings for REST means we have to place every parameter in the URL query. This is not very convenient if there are many parameters. But even worse, some types like arrays/slices aren't supported in query parameters and map types are very awkward to use.
So we add POST mappings for the calls that have many or more complex request parameters.
Pull Request Checklist
MinLndVersionif your PR uses new RPC methods or fields oflnd.