frdrpc: add JSON/WASM client stubs for LNC, move server code into own package #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linter complaining about import groups |
To avoid the frdrpc package having dependencies to other libraries and making using the JSON/WASM stubs hard, we extract all the business logic and RPC server code into its own package called frdrpcserver.
|
Thanks, fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To include Faraday in LNC we need to generate JSON/WASM stubs for
frdrpcas well.And to make it easy to use
frdrpcin other projects, we don't want to pull in the full server logic with all its dependencies as well. That's why we move the server logic into its own package calledfrdrpcserver.Pull Request Checklist
release_notes.mdif your PR contains major features, breakingchanges or bugfixes
MinLndVersionif your PR uses new RPC methods or fields oflnd.