Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't interpret decayed data as we've failed to send tiny values #3368

Merged
merged 1 commit into from
Nov 13, 2024

Commits on Oct 14, 2024

  1. Don't interpret decayed data as we've failed to send tiny values

    When we're calculating the success probability for min-/max-bucket
    pairs and are looking at the 0th' min-bucket, we only look at the
    highest max-bucket to decide the success probability. We ignore
    max-buckets which have a value below `BUCKET_FIXED_POINT_ONE` to
    only consider values which aren't substantially decayed.
    
    However, if all of our data is substantially decayed, this filter
    causes us to conclude that the highest max-bucket is bucket zero
    even though we really should then be looking at any bucket.
    
    We make this change here, looking at the highest non-zero
    max-bucket if no max-buckets have a value above
    `BUCKET_FIXED_POINT_ONE`.
    TheBlueMatt committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    41a91a3 View commit details
    Browse the repository at this point in the history