Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt: Run on util/* (1/2) #3324

Merged
merged 22 commits into from
Oct 1, 2024

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Sep 18, 2024

The diff is a bit larger for this one, but AFAICT the changes look mostly reasonable (besides the oddity commented below).

FWIW, I had a look at currently open inflight PRs and the conflicts should be minimal if I'm not overlooking something.

This is PR 1/2, follow-up: #3323.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 89.57055% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.64%. Comparing base (66fb520) to head (d68a484).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/persist.rs 89.41% 17 Missing and 3 partials ⚠️
lightning/src/util/macro_logger.rs 87.87% 0 Missing and 4 partials ⚠️
lightning/src/util/message_signing.rs 50.00% 4 Missing ⚠️
lightning/src/util/errors.rs 72.72% 3 Missing ⚠️
lightning/src/util/indexed_map.rs 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3324      +/-   ##
==========================================
- Coverage   89.66%   89.64%   -0.02%     
==========================================
  Files         126      126              
  Lines      102676   102817     +141     
  Branches   102676   102817     +141     
==========================================
+ Hits        92062    92171     +109     
- Misses       7894     7923      +29     
- Partials     2720     2723       +3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but the last commit, which starts to get into our functional tests which need to be cleaned up to be more readable, allowing them to also be more condensed.

lightning/src/util/persist.rs Outdated Show resolved Hide resolved
lightning/src/util/persist.rs Outdated Show resolved Hide resolved
lightning/src/util/persist.rs Outdated Show resolved Hide resolved
lightning/src/util/persist.rs Outdated Show resolved Hide resolved
lightning/src/util/persist.rs Outdated Show resolved Hide resolved
@tnull
Copy link
Contributor Author

tnull commented Sep 19, 2024

Rebased after #3327 landed and addressed outstanding comments.

);
io::Error::new(io::ErrorKind::Other, "Monitor update failed")
})?;
log_error!(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol wtf, why is this aligned with the next line up even though its in the method started by the { on the next line up...

@TheBlueMatt TheBlueMatt merged commit 4147de2 into lightningdevkit:main Oct 1, 2024
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants