Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement accepting dual-funded channels without contributing #3137

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Implement accepting dual-funded channels without contributing #3137

merged 15 commits into from
Nov 20, 2024

Commits on Nov 18, 2024

  1. Add dual-funding spec links

    @dunxen
    dunxen committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    899d5f5 View commit details
    Browse the repository at this point in the history

  2. Remove dual_funding cfg attributes 

    We'll only gate public API related to contributing toward an inbound or opening
a dual funded channel.
    @dunxen
    dunxen committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7e23afc View commit details
    Browse the repository at this point in the history

  3. Add interactive tx constructor to all V2-related channel structs 

    Here we add the `interactive_tx_constructor` field to the `Channel`,
`OutboundV2Channel`, and `InboundV2Channel` structs.
    @dunxen
    dunxen committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    bb81598 View commit details
    Browse the repository at this point in the history

  4. Remove unused Channel::dual_funding_channel_context 

    For now this is unneeded as we do not provide any inputs as channel
acceptor and we do not allow creating outbound channels yet. It will
be re-added when that functionality is introduced.
    @dunxen
    dunxen committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b0dc394 View commit details
    Browse the repository at this point in the history

  5. Add features in InteractiveTxConstructor requried for V2 chan accept 

    1. InteractiveTxConstructorArgs is introduced to act as a single, more
   readable input to InteractiveTxConstructor::new().
2. Various documentation updates.
    @dunxen
    dunxen committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    f71bbb9 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Implement support for accepting V2 channels

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    24ba584 View commit details
    Browse the repository at this point in the history

  2. Introduce InteractiveTxSigningSession for signing interactively const… 

    …ructed txs
    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    684b3b7 View commit details
    Browse the repository at this point in the history

  3. Handle initial commitment_signed for V2 channels

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    982e25d View commit details
    Browse the repository at this point in the history

  4. Handle re-establishment next_funding_txid

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c79b49d View commit details
    Browse the repository at this point in the history

  5. Add option_dual_fund feature

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f793bf8 View commit details
    Browse the repository at this point in the history

  6. Temporarily allow some unused dual-funding code

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c3896b5 View commit details
    Browse the repository at this point in the history

  7. Add manual testing for accepting dual-funded channels

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2deb41a View commit details
    Browse the repository at this point in the history

  8. Fix docs to indicate OpenChannelRequest is NOT persisted across restarts

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c762c6b View commit details
    Browse the repository at this point in the history

  9. Remove unused muts in channel tests

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    85d58ba View commit details
    Browse the repository at this point in the history

  10. Add pending release notes for accepting dual-funded channels

    @dunxen
    dunxen committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    dd190ae View commit details
    Browse the repository at this point in the history