Re-add one-hop onion message fuzzing test #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some editors like vim slow to a crawl when scrolling over long strings when syntax highlighting is turned on. Limit the length in fuzz strings to avoid this.
Revert fuzz test removal in 6dc4223. The test originally checked that OnionMessenger would fail for one-hop blinded paths. The commit added support for such paths, but changing the checks was not sufficient since the node was not connected to the introduction node of the reply path. This is required in order to work with the trivial TestMessageRouter. Fix this by explicitly connecting the nodes.
jkczyz
force-pushed
the
2023-10-onion-message-fuzz
branch
from
f4a9aea
to
bb1a4f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2686 +/- ##
==========================================
- Coverage 88.78% 88.76% -0.02%
==========================================
Files 112 112
Lines 88474 88474
Branches 88474 88474
==========================================
- Hits 78553 78538 -15
- Misses 7686 7701 +15
Partials 2235 2235 ☔ View full report in Codecov by Sentry. |
valentinewallace
approved these changes
Oct 30, 2023
TheBlueMatt
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert fuzz test removal in 6dc4223. The test originally checked that
OnionMessengerwould fail for one-hop blinded paths. The commit added support for such paths, but changing the checks was not sufficient since the node was not connected to the introduction node of the reply path. This is required in order to work with the trivialTestMessageRouter. Fix this by explicitly connecting the nodes.Fixes #2671