Update docs on MonitorEvent::HolderForceClosed
#2668
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
reviewed
Oct 17, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
+ Coverage 89.09% 89.95% +0.86%
==========================================
Files 112 112
Lines 86959 94739 +7780
Branches 86959 94739 +7780
==========================================
+ Hits 77476 85225 +7749
+ Misses 7255 7232 -23
- Partials 2228 2282 +54
☔ View full report in Codecov by Sentry. |
|
LGTM after squash |
In a96e2fe we renamed `MonitorEvent::CommitmentTxConfirmed` to `HolderForceClosed` to better document what actually happened. However, we failed to update the documentation on the type, which we do here. Pointed out by @yellowred.
TheBlueMatt
force-pushed
the
2023-10-fix-doc
branch
from
12e9b6a to
323366c
Compare
wpaulino
approved these changes
Oct 20, 2023
G8XSU
approved these changes
Oct 30, 2023
valentinewallace
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a96e2fe we renamed
MonitorEvent::CommitmentTxConfirmedtoHolderForceClosedto better document what actually happened. However, we failed to update the documentation on the type, which we do here.Pointed out by @yellowred.