Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid applying onion's channel updates in an observable way #2666

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Avoid applying onion's channel updates in an observable way #2666

merged 2 commits into from
Oct 19, 2023

Commits on Oct 19, 2023

  1. Allow to verify channel updates without applying them 

    We introduce a new `NetworkGraph::verify_channel_update` method that
allows to check whether an update would be applied by `update_channel`.
    @tnull
    tnull committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    1dffb20 View commit details
    Browse the repository at this point in the history

  2. Don't apply PathFailure::ChannelUpdateMessage 

    If we receive a channel update from an intermediary via a failure onion
we shouldn't apply them in a persisted and network-observable way to our
network graph, as this might introduce a privacy leak. Here, we
therefore avoid applying such updates to our network graph.
    @tnull
    tnull committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    1c35255 View commit details
    Browse the repository at this point in the history