Remove anchors config flag #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
force-pushed
the
remove-anchors-flag
branch
from
f46a8ae to
1a3bad8
Compare
|
There's a few spurious anchors flags in the CI script, though they'll be ignored now. |
TheBlueMatt
reviewed
Jun 23, 2023
wpaulino
force-pushed
the
remove-anchors-flag
branch
from
1a3bad8 to
d0d6490
Compare
wpaulino
force-pushed
the
remove-anchors-flag
branch
from
d0d6490 to
5cddb23
Compare
TheBlueMatt
previously approved these changes
Jun 23, 2023
valentinewallace
previously approved these changes
Jun 23, 2023
| /// Processes [`SpendableOutputs`] events produced from each [`ChannelMonitor`] upon maturity. | ||
| /// | ||
| /// For channels featuring anchor outputs, this method will also process [`BumpTransaction`] | ||
| /// events produced from each [`ChannelMonitor`] while there is a balance to claim onchain | ||
| /// within each channel. As the confirmation of a commitment transaction may be critical to the | ||
| /// safety of funds, this method must be invoked frequently, ideally once for every chain tip |
There was a problem hiding this comment.
Generally I'd prefer if the docs updates were in their own commit, don't care much here though
Now that all of the core functionality for anchor outputs has landed, we're ready to remove the config flag that was temporarily hiding it from our API.
wpaulino
dismissed stale reviews from valentinewallace and TheBlueMatt
via
82b646c
wpaulino
force-pushed
the
remove-anchors-flag
branch
from
5cddb23 to
82b646c
Compare
|
Would it be difficult to fix the warnings? Leaving them can make it easy to miss relevant warnings in local development when working off of |
|
They weren't introduced by this PR, but rather by #2361. |
TheBlueMatt
approved these changes
Jun 23, 2023
valentinewallace
approved these changes
Jun 23, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
+ Coverage 90.30% 90.32% +0.01%
==========================================
Files 106 106
Lines 54900 54888 -12
Branches 54900 54888 -12
==========================================
- Hits 49576 49575 -1
+ Misses 5324 5313 -11
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all of the core functionality for anchor outputs has landed, we're ready to remove the config flag that was temporarily hiding it from our API.
Depends on #2361.