Prefactor PaymentParameters for blinded recipients
#2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
f7d4237
to
215ea05
Compare
1 task
TheBlueMatt
reviewed
May 3, 2023
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
215ea05
to
aec3d4d
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
- Coverage 91.58% 91.57% -0.01%
==========================================
Files 104 105 +1
Lines 51993 60983 +8990
Branches 51993 60983 +8990
==========================================
+ Hits 47616 55848 +8232
- Misses 4377 5135 +758
☔ View full report in Codecov by Sentry. |
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
aec3d4d
to
0275873
Compare
Minor changes in preparation for supporting route blinding in PaymentParameters. In the next commit, we'll be moving more unblinded-payee-specific fields from the top level parameters into the clear enum variant.
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1e3d7af
to
0f823fb
Compare
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
0f823fb
to
4729342
Compare
jkczyz
reviewed
May 4, 2023
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
4729342
to
554c1fc
Compare
jkczyz
previously approved these changes
May 4, 2023
TheBlueMatt
reviewed
May 4, 2023
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
2 times, most recently
from
1298418
to
dca58c3
Compare
TheBlueMatt
reviewed
May 6, 2023
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
dca58c3
to
9d7a370
Compare
jkczyz
reviewed
May 8, 2023
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
9d7a370
to
fb9983c
Compare
jkczyz
reviewed
May 8, 2023
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
fb9983c
to
a84e832
Compare
Since blinded payees don't have one
Since blinded payees don't have this.
Since blinded pay params won't have this value.
valentinewallace
force-pushed
the
2023-04-blinded-pathfinding-groundwork-2
branch
from
a84e832
to
d56672c
Compare
jkczyz
approved these changes
May 8, 2023
TheBlueMatt
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several pay params fields are specific to either blinded or unblinded recipients, so here we use an enum to separate the two cases and ensure that an invalid
PaymentParameterscan't be created.