Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PaymentPathFailed::retry #2063

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Remove PaymentPathFailed::retry #2063

merged 4 commits into from
Mar 13, 2023

Commits on Mar 13, 2023

  1. Remove PaymentPathFailed::retry 

    We now support automatic retries in ChannelManager and no longer support manual
retries, so the field is useless.
    @valentinewallace
    valentinewallace committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    753e4ce View commit details
    Browse the repository at this point in the history

  2. Remove HTLCSource::OutboundRoute::payment_params 

    No longer used since it is no longer used to construct PaymentPathFailed events
    @valentinewallace
    valentinewallace committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    2939649 View commit details
    Browse the repository at this point in the history

  3. Remove payment_params from send_payent_along_path 

    It's unused since it no longer inserts it into HTLCSource
    @valentinewallace
    valentinewallace committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f6823c5 View commit details
    Browse the repository at this point in the history

  4. Ensure payment_params present when checking is_retryable_now

    @valentinewallace
    valentinewallace committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f89b7d6 View commit details
    Browse the repository at this point in the history