Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 12 invoice_request encoding and building #1738

Merged
merged 10 commits into from
Dec 12, 2022
Merged

BOLT 12 invoice_request encoding and building #1738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4b8b17d
Reduce visibility for offer auxiliary types
jkczyz Dec 2, 2022
3e17e7f
Remove unused mut from OfferBuilder::amount_msats
jkczyz Nov 28, 2022
0c62164
Invoice request message interface and data format
jkczyz Sep 19, 2022
05bf27f
Schnorr Signature serialization
jkczyz Jun 24, 2022
a7adc76
Merkle root hash computation
jkczyz Aug 9, 2022
59a7bd2
Invoice request raw byte encoding and decoding
jkczyz Aug 23, 2022
13ba7cc
Builder for creating invoice requests
jkczyz Aug 31, 2022
d666eb6
Invoice request building tests
jkczyz Nov 11, 2022
984c906
Invoice request parsing tests
jkczyz Nov 16, 2022
b25c8df
Add BOLT 12 merkle root test for `invoice_request`
jkczyz Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lightning/src/ln/features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ mod sealed {
BasicMPP,
]);
define_context!(OfferContext, []);
define_context!(InvoiceRequestContext, []);
// This isn't a "real" feature context, and is only used in the channel_type field in an
// `OpenChannel` message.
define_context!(ChannelTypeContext, [
Expand Down Expand Up @@ -367,7 +368,8 @@ mod sealed {
supports_keysend, requires_keysend);

#[cfg(test)]
define_feature!(123456789, UnknownFeature, [NodeContext, ChannelContext, InvoiceContext, OfferContext],
define_feature!(123456789, UnknownFeature,
[NodeContext, ChannelContext, InvoiceContext, OfferContext, InvoiceRequestContext],
"Feature flags for an unknown feature used in testing.", set_unknown_feature_optional,
set_unknown_feature_required, supports_unknown_test_feature, requires_unknown_test_feature);
}
Expand Down Expand Up @@ -426,8 +428,10 @@ pub type NodeFeatures = Features<sealed::NodeContext>;
pub type ChannelFeatures = Features<sealed::ChannelContext>;
/// Features used within an invoice.
pub type InvoiceFeatures = Features<sealed::InvoiceContext>;
/// Features used within an offer.
/// Features used within an `offer`.
pub type OfferFeatures = Features<sealed::OfferContext>;
/// Features used within an `invoice_request`.
pub type InvoiceRequestFeatures = Features<sealed::InvoiceRequestContext>;

/// Features used within the channel_type field in an OpenChannel message.
///
Expand Down Expand Up @@ -735,6 +739,7 @@ macro_rules! impl_feature_tlv_write {

impl_feature_tlv_write!(ChannelTypeFeatures);
impl_feature_tlv_write!(OfferFeatures);
impl_feature_tlv_write!(InvoiceRequestFeatures);

#[cfg(test)]
mod tests {
Expand Down
Loading