Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MultiThreadedLockableScoreLock MultiThreadedScoreLock #1734

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

as the first is quite a mouthful, and the second isn't materially less specific.

As suggested by Val at #1730 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Base: 90.73% // Head: 90.70% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9eef784) compared to base (5211bfd).
Patch has no changes to coverable lines.

❗ Current head 9eef784 differs from pull request most recent head ba021f8. Consider uploading reports for the commit ba021f8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1734      +/-   ##
==========================================
- Coverage   90.73%   90.70%   -0.03%     
==========================================
  Files          87       87              
  Lines       46688    46688              
  Branches    46688    46688              
==========================================
- Hits        42361    42348      -13     
- Misses       4327     4340      +13     
Impacted Files Coverage Δ
lightning/src/routing/scoring.rs 96.14% <ø> (ø)
lightning/src/chain/onchaintx.rs 94.71% <0.00%> (-0.92%) ⬇️
lightning/src/util/events.rs 38.13% <0.00%> (-0.27%) ⬇️
lightning/src/ln/functional_tests.rs 96.96% <0.00%> (-0.11%) ⬇️
lightning/src/ln/channelmanager.rs 85.09% <0.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dunxen dunxen changed the title Rename MultiThreadedLockableScoreLock MultiThreadedLockedScore Rename MultiThreadedLockableScoreLock MultiThreadedScoreLock Sep 23, 2022
@dunxen
Copy link
Contributor

dunxen commented Sep 23, 2022

Just looks like the new name in the commit doesn't match the actual new name.

dunxen
dunxen previously approved these changes Sep 23, 2022
as the first is quite a mouthful, and the second isn't materially
less specific.
@TheBlueMatt
Copy link
Collaborator Author

Oops, lol. Val suggested one and my fingers wrote something else. The something else is easier for bindings to identify as a lock anyway, so just reworded the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants