Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement channel_type negotiation #1078

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Implement channel_type negotiation #1078

merged 4 commits into from
Nov 3, 2021

Commits on Oct 22, 2021

  1. Fix cargo doc on older rustc 

    Apparently at least rustc 1.48 doesn't support `Self` in doc links,
so we make it explicit.
    @TheBlueMatt
    TheBlueMatt committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    d0c3fb7 View commit details
    Browse the repository at this point in the history

  2. Add a ChannelTypeFeatures features object for the new channel_type 

    Its semantics are somewhat different from existing features,
however not enough to merit a different struct entirely.
Specifically, it only supports required features (if you send a
channel_type, the counterparty has to accept it wholesale or try
again, it cannot select only a subset of the flags) and it is
serialized differently (only appearing in TLVs).
    @TheBlueMatt
    TheBlueMatt committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    e847c87 View commit details
    Browse the repository at this point in the history

  3. Support de/ser of the new channel_type field in open_channel

    @TheBlueMatt
    TheBlueMatt committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    b7a8dd4 View commit details
    Browse the repository at this point in the history

  4. Support send/recv'ing the new channel_type field in open_channel 

    This implements the channel type negotiation, though as we currently
only support channels with only static_remotekey set, it doesn't
implement the negotiation explicitly.
    @TheBlueMatt
    TheBlueMatt committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    db2e7e7 View commit details
    Browse the repository at this point in the history