Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose TLV serialization/deserialization macros #1539

Closed
mariocynicys opened this issue Jun 13, 2022 · 0 comments · Fixed by #1823
Closed

Expose TLV serialization/deserialization macros #1539

mariocynicys opened this issue Jun 13, 2022 · 0 comments · Fixed by #1823
Milestone
0.1

Comments

@mariocynicys
Copy link
Contributor

mariocynicys commented Jun 13, 2022 •
edited by tnull
Loading

Macros found in lightning::utils::ser_macros could be pretty useful to LDK users.

Some use cases would be:

  • Implementing custom messages containing TLVS.

The macro that interests me (and anyone implementing custom messages) is this one (could this possibly be made public?), but we should investigate if there are other serialization/deserialization macros which would be also useful to be made public.
@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Jun 13, 2022
@valentinewallace valentinewallace mentioned this issue Jun 17, 2022
Merged
mariocynicys added a commit to mariocynicys/rust-teos that referenced this issue Jun 19, 2022
@mariocynicys
WIP: Adding tower messages
6297db5 
This involved LDK related work to use the macros in `teos-common::lightning_messages`.
LDK fork used: https://github.com/meryacine/rust-lightning/tree/expose-tlv-macros
The LDK fork above is implementing what's missing in this issue: lightningdevkit/rust-lightning#1539. which is expected to land in LDK v0.1
@mariocynicys mariocynicys mentioned this issue Jun 19, 2022
Closed
mariocynicys added a commit to mariocynicys/rust-teos that referenced this issue Jun 19, 2022
@mariocynicys
WIP: Adding tower messages
817c6bb 
This involved LDK related work to use the macros in `teos-common::lightning_messages`.
LDK fork used: https://github.com/meryacine/rust-lightning/tree/expose-tlv-macros
The LDK fork above is implementing what's missing in this issue: lightningdevkit/rust-lightning#1539. which is expected to land in LDK v0.1
mariocynicys added a commit to mariocynicys/rust-teos that referenced this issue Aug 2, 2022
@mariocynicys
WIP: Adding tower messages
c7aeee9 
This involved LDK related work to use the macros in `teos-common::lightning_messages`.
LDK fork used: https://github.com/meryacine/rust-lightning/tree/expose-tlv-macros
The LDK fork above is implementing what's missing in this issue: lightningdevkit/rust-lightning#1539. which is expected to land in LDK v0.1
@tnull tnull mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Expose impl_writeable_tlv_based macro mariocynicys/rust-lightning
2 participants
@TheBlueMatt @mariocynicys