Skip to content

Commit

Permalink
Move the channel_announcement process log into NetworkGraph
Browse files Browse the repository at this point in the history
This ensures its always written after we update the graph, no
matter how we updated the graph.
  • Loading branch information
TheBlueMatt committed Feb 8, 2023
1 parent f79f750 commit 4223d2e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lightning/src/routing/gossip.rs
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,6 @@ where U::Target: UtxoLookup, L::Target: Logger

fn handle_channel_announcement(&self, msg: &msgs::ChannelAnnouncement) -> Result<bool, LightningError> {
self.network_graph.update_channel_from_announcement(msg, &self.utxo_lookup)?;
log_gossip!(self.logger, "Added channel_announcement for {}{}", msg.contents.short_channel_id, if !msg.contents.excess_data.is_empty() { " with excess uninterpreted data!" } else { "" });
Ok(msg.contents.excess_data.len() <= MAX_EXCESS_BYTES_FOR_RELAY)
}

Expand Down Expand Up @@ -1559,7 +1558,10 @@ impl<L: Deref> NetworkGraph<L> where L::Target: Logger {
announcement_received_time,
};

self.add_channel_between_nodes(msg.short_channel_id, chan_info, utxo_value)
self.add_channel_between_nodes(msg.short_channel_id, chan_info, utxo_value)?;

log_gossip!(self.logger, "Added channel_announcement for {}{}", msg.short_channel_id, if !msg.excess_data.is_empty() { " with excess uninterpreted data!" } else { "" });
Ok(())
}

/// Marks a channel in the graph as failed if a corresponding HTLC fail was sent.
Expand Down

0 comments on commit 4223d2e

Please sign in to comment.