Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BDK-based KeysManager example #183

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Dec 16, 2022

This introduces a basic Rust example on how to wrap KeysManager in order to make outputs spendable by a BDK wallet.

Probably not complete as it needs to be complemented with Java/Kotlin counterparts.

@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for lightningdevkit ready!

Name Link
🔨 Latest commit 9d3aae8
🔍 Latest deploy log https://app.netlify.com/sites/lightningdevkit/deploys/64d1232d321dc70008f20263
😎 Deploy Preview https://deploy-preview-183--lightningdevkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tnull tnull force-pushed the 2022-12-add-keysinterface-example branch 8 times, most recently from 154b4a6 to bd2b1e0 Compare December 19, 2022 10:36
@tnull
Copy link
Contributor Author

tnull commented Dec 21, 2022

Will also need a rebase after lightningdevkit/rust-lightning#1910 / lightningdevkit/rust-lightning#1930 got in.

@tnull tnull marked this pull request as draft January 17, 2023 23:50
@ConorOkus
Copy link
Contributor

@tnull I think this might be good to go. We don't need to wait for Java/Kotlin examples but I'm currently implementing in kotlin now so should have it shortly. I just created a discussion to make sure I'm implementing it right.

@tnull
Copy link
Contributor Author

tnull commented Mar 27, 2023

@tnull I think this might be good to go. We don't need to wait for Java/Kotlin examples but I'm currently implementing in kotlin now so should have it shortly. I just created a discussion to make sure I'm implementing it right.

Heh, have to admit I've almost forgotten about this one. Updated for the recent removal of KeysInterface.

@wpaulino Any thoughts what else to add while I'm here? Possibly more specifics regarding the individual SignerProvider/NodeSigner/EntropySource trinity?

@tnull tnull marked this pull request as ready for review March 27, 2023 12:59
@tnull tnull force-pushed the 2022-12-add-keysinterface-example branch from bd2b1e0 to b760199 Compare March 27, 2023 13:29
@wpaulino
Copy link
Contributor

@wpaulino Any thoughts what else to add while I'm here? Possibly more specifics regarding the individual SignerProvider/NodeSigner/EntropySource trinity?

Not really, I think the example you've added is good enough. Realistically, users won't be implementing their own versions of these traits other than the common case already covered here, and on the rare case they need to, the rust docs should help.

@tnull
Copy link
Contributor Author

tnull commented Mar 28, 2023

Not really, I think the example you've added is good enough. Realistically, users won't be implementing their own versions of these traits other than the common case already covered here, and on the rare case they need to, the rust docs should help.

Yeah, was thinking whether generally something came to mind we want to add here regarding keys management etc., but probably it's fine to land this as-is for now.

@tnull tnull force-pushed the 2022-12-add-keysinterface-example branch 3 times, most recently from 878f196 to 700aaf4 Compare March 28, 2023 07:34
@tnull
Copy link
Contributor Author

tnull commented Aug 4, 2023

@ConorOkus Did you end up making any progress on the Java side of things?

@ConorOkus
Copy link
Contributor

@ConorOkus Did you end up making any progress on the Java side of things?

No but let's merge this, I've created and issue to follow up with those examples. cc @Roy0Anonymous to add Swift example

@tnull tnull force-pushed the 2022-12-add-keysinterface-example branch from 700aaf4 to 9d3aae8 Compare August 7, 2023 17:00
@tnull
Copy link
Contributor Author

tnull commented Aug 7, 2023

No but let's merge this, I've created and issue to follow up with those examples. cc @Roy0Anonymous to add Swift example

Alright, updated as there were minor interface changes since this PR was opened.

@ConorOkus ConorOkus merged commit cbfbd6e into lightningdevkit:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants