-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BDK-based KeysManager
example
#183
Add BDK-based KeysManager
example
#183
Conversation
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
154b4a6
to
bd2b1e0
Compare
Will also need a rebase after lightningdevkit/rust-lightning#1910 / lightningdevkit/rust-lightning#1930 got in. |
@tnull I think this might be good to go. We don't need to wait for Java/Kotlin examples but I'm currently implementing in kotlin now so should have it shortly. I just created a discussion to make sure I'm implementing it right. |
Heh, have to admit I've almost forgotten about this one. Updated for the recent removal of @wpaulino Any thoughts what else to add while I'm here? Possibly more specifics regarding the individual |
bd2b1e0
to
b760199
Compare
Not really, I think the example you've added is good enough. Realistically, users won't be implementing their own versions of these traits other than the common case already covered here, and on the rare case they need to, the rust docs should help. |
Yeah, was thinking whether generally something came to mind we want to add here regarding keys management etc., but probably it's fine to land this as-is for now. |
878f196
to
700aaf4
Compare
@ConorOkus Did you end up making any progress on the Java side of things? |
No but let's merge this, I've created and issue to follow up with those examples. cc @Roy0Anonymous to add Swift example |
700aaf4
to
9d3aae8
Compare
Alright, updated as there were minor interface changes since this PR was opened. |
This introduces a basic Rust example on how to wrap
KeysManager
in order to make outputs spendable by a BDK wallet.Probably not complete as it needs to be complemented with Java/Kotlin counterparts.