LSPS2: DRY logic around getting next payment from queue #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncantrell97
force-pushed
the
dry-payment-queue-pop
branch
3 times, most recently
from
fa25cfd
to
0513e0c
Compare
johncantrell97
force-pushed
the
dry-payment-queue-pop
branch
from
0513e0c
to
5172df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #137
In htlc_intercepted, htlc_handling_failed, channel_ready, and payment_forwarded (in #134) we try to get a payment from the queue and construct the new state and a forward payment action from it. The code is identical in all four cases so this extracts it to a single function.