-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to LDK 0.0.121 #126
Conversation
Just curious if this is still in the works :) |
LDK 0.0.119 is available for some time now -- unless at the time of creation of this PR. However, more adaption is needed, TODO. |
Right, but do you intend to go ahead with this PR? If not, I'd be happy to take it over and upgrade |
Yes, I plan to do this in next 1-2 days, but no hard commitment :D |
I run into a small problem here: |
Ugh, that might indeed be an issue we should fix upstream. Not sure if we need to find a (likely ugly) workaround here and roll it back, or wait for the upstream change though. @TheBlueMatt Any opinion on this? |
I did a workaround, by creating a version of |
Also mentioning @johncantrell97 , the author of #2773 . |
Ugh, thanks for doing this! Sorry it took a while to get back to this. We'll want to (partially) revert [#2773.](lightningdevkit/rust-lightning#2773. |
Update: PR #2773 was partially reverted by PR #2822 . |
LDK v0.0.120 has been released, includes #2822. |
8ac6a80
to
d33c07e
Compare
There's one CI test failure, one dependency lib was not found, |
Bumped from 120 to 121. |
Also updated minimal tested Rust version to |
b70d39c
to
37d9df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mod one unwrap
I missed before (sorry for that).
@optout21 I think this should be very close to landing, mod the nits above. |
Done now. Thanks for reminding, it slid lower in my to-do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hey, dunno if anyone will see this, but I was wondering if the team considered using |
|
Updated to LDK
0.0.121
and bitcoin library0.30.2
.Also updated MSRV to
1.63
, as LDK requires that (since 0.0.119).Fixes #125 .
TODO:
Relevant changes in LDK:
temporary_channel_id
tocreate_channel
. #2699