This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Add: Home, What, About and Self Hosting info pages with routing (DRAFT) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is great, thanks! Components architecture for svelte kit should look like:
using the 'lib' directory makes imports really easy:
we will probably need @bitkarrot to help clarify some of the self hosting stuff. I should have a PR with the base nostr-kit logic pushed tonight/tomorrow |
|
OK, @amsalmeron @eriknewland gimmie a day or two to catch up here. Am way behind. if you don't get a response in a day or so, ping me again. |
bitkarrot
reviewed
Aug 9, 2023
| <p>6. Once deployment is complete, your project will be live on Heroku and you will be able to access it using the URL provided</p> | ||
| </ol> | ||
| </ol> | ||
| <h3>Congratualtions</h3> |
There was a problem hiding this comment.
Some typos in the 'Congratulations' section on https://nostrkit.vercel.app/selfhosting, please spell check and proof.
|
@eriknewland and I will discuss UX/UI in the next day or so |
bitkarrot
suggested changes
Aug 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5 : create static pages What, About and Self Hosting. Also added a Home page at the root. Set up routing in +page.svelete. Components should probably be in another directory, and proof reading is appreciated.
This is a DRAFT. CSS non existent.
Vercel: https://nostrkit.vercel.app/