-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anchors: follow up changes after initial zero fee anchors merge #903
Conversation
I don't see this one? Could you also fix the tiny typo referenced here: https://github.com/lightningnetwork/lightning-rfc/pull/824/files#r698775217 ? |
We can fix this too, I just noticed:
The "or |
This too...:
|
See my comment here : https://github.com/lightningnetwork/lightning-rfc/pull/824/files#r698781292. At least might be good to precise combination should only be done with transactions within the same "safety" domain (equal or 0-value |
@Roasbeef any progress on this PR? I can take it over if you don't have time, let me know. |
Pushed up extra commits addressing Rusty's comment.
TBH, it's been so long with this PR that I forgot what I was going to do here... |
So we can remove references to anchors here, as you need static key in order to support it, so that reference is redundant.
159de44
to
779f366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 779f366
Fixup changes: