Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update closing_signed fee requirement #847

Merged
merged 7 commits into from
Aug 31, 2021
Merged

Commits on Jun 30, 2021

  1. Update closing_signed fee requirement

    With anchor outputs, we can keep the commit tx feerate lower than the real
    on-chain feerate. That means that when closing the channel, the resulting
    fee will not necessarily be lower than the current commit tx fee, this
    requirement doesn't make sense to be strict.
    t-bast committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    69a11c2 View commit details
    Browse the repository at this point in the history
  2. Add fee range TLV

    Both sides can optionally include a preferred fee range in their
    `closing_signed`. This lets their peer know what fees they find acceptable
    and should simplify negotiation.
    t-bast committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    f029164 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Use warning instead of disconnecting

    When fee ranges are incompatible, disconnecting doesn't help much: upon
    reconnection, the same `closing_signed` will be sent again.
    
    It makes more sense instead to send a `warning` and keep the connection open.
    The node operator should notice that warning and instruct its node to send
    another `closing_signed` with a different fee range (if it agrees) or may
    choose to ignore it and wait, or to force-close.
    t-bast committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    8683525 View commit details
    Browse the repository at this point in the history
  2. Remove fee below commit fee requirement

    As discussed during the spec meeting, we can remove that requirement.
    t-bast committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    c990020 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Fail channel when deadlocked

    If we're disagreeing on the closing fee_range, no progress will happen,
    so we force-close the channel after some time to unblock the funds.
    t-bast committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    034486c View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. Fix indent

    t-bast committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    aaae6bc View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Remove warning message

    And clarify introduction text.
    t-bast committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    92d2af0 View commit details
    Browse the repository at this point in the history