-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update closing_signed fee requirement #847
Merged
Merged
Commits on Jun 30, 2021
-
Update closing_signed fee requirement
With anchor outputs, we can keep the commit tx feerate lower than the real on-chain feerate. That means that when closing the channel, the resulting fee will not necessarily be lower than the current commit tx fee, this requirement doesn't make sense to be strict.
Configuration menu - View commit details
-
Copy full SHA for 69a11c2 - Browse repository at this point
Copy the full SHA 69a11c2View commit details -
Both sides can optionally include a preferred fee range in their `closing_signed`. This lets their peer know what fees they find acceptable and should simplify negotiation.
Configuration menu - View commit details
-
Copy full SHA for f029164 - Browse repository at this point
Copy the full SHA f029164View commit details
Commits on Jul 19, 2021
-
Use warning instead of disconnecting
When fee ranges are incompatible, disconnecting doesn't help much: upon reconnection, the same `closing_signed` will be sent again. It makes more sense instead to send a `warning` and keep the connection open. The node operator should notice that warning and instruct its node to send another `closing_signed` with a different fee range (if it agrees) or may choose to ignore it and wait, or to force-close.
Configuration menu - View commit details
-
Copy full SHA for 8683525 - Browse repository at this point
Copy the full SHA 8683525View commit details -
Remove fee below commit fee requirement
As discussed during the spec meeting, we can remove that requirement.
Configuration menu - View commit details
-
Copy full SHA for c990020 - Browse repository at this point
Copy the full SHA c990020View commit details
Commits on Jul 21, 2021
-
If we're disagreeing on the closing fee_range, no progress will happen, so we force-close the channel after some time to unblock the funds.
Configuration menu - View commit details
-
Copy full SHA for 034486c - Browse repository at this point
Copy the full SHA 034486cView commit details
Commits on Aug 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for aaae6bc - Browse repository at this point
Copy the full SHA aaae6bcView commit details
Commits on Aug 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 92d2af0 - Browse repository at this point
Copy the full SHA 92d2af0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.