Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bolt-09: reserve feature bits for option_anchors_zero_fee_htlc_tx #828

Merged
merged 1 commit into from
Jan 4, 2021
Merged

bolt-09: reserve feature bits for option_anchors_zero_fee_htlc_tx #828

merged 1 commit into from
Jan 4, 2021

Conversation

halseth
Copy link
Contributor

@halseth halseth commented Dec 22, 2020

See #824. This PR only reserves the feature bits.

@halseth halseth mentioned this pull request Dec 22, 2020
Closed
18 tasks
t-bast
t-bast reviewed Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, just needs some fixing for the CI (I think txs and vuln can be added to the dictionary)

@halseth
Copy link
Contributor Author

halseth commented Dec 22, 2020

did some renaming, still had to add sighash to the dictionary.

t-bast
t-bast approved these changes Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c4f9407

@cdecker
Copy link
Collaborator

cdecker commented Dec 22, 2020

ACK c4f9407

@t-bast t-bast mentioned this pull request Dec 28, 2020
Closed
16 tasks
@t-bast t-bast merged commit a00418f into lightning:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halseth @cdecker @t-bast