Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolt3: test vector fixes #1056

Merged
merged 4 commits into from
Feb 28, 2023

Commits on Feb 22, 2023

  1. BOLT 03: fix no htlc single anchor test

    The commitment transaction tests are all meant to use the same funding
    transaction which has an amount of 10000000000 msat. The LocalBalance
    and RemoteBalance along with the value of any htlcs should always add up
    to this amount.
    
    This commit updates the `simple commitment tx with no HTLCs and single
    anchor` anchors test to comply with the above.
    ellemouton committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    42d4e42 View commit details
    Browse the repository at this point in the history
  2. BOLT 03: fix legacy same amt and pre-image test vector

    The `commitment tx with 3 htlc outputs, 2 offered having the same amount
    and preimage` test was not correctly updated after the value of test
    htlc 6 was changed to 5000001 and the cltv expiry of test htlc 5 was
    changed to 506. This commit updates the legacy test accordingly.
    ellemouton committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    6d09e31 View commit details
    Browse the repository at this point in the history
  3. BOLT 03: fix static-remote same amt and pre-image test vector

    The `commitment tx with 3 htlc outputs, 2 offered having the same amount
    and preimage` test was not correctly updated after the value of test
    htlc 6 was changed to 5000001 and the cltv expiry of test htlc 5 was
    changed to 506. This commit updates the static-remote test accordingly.
    ellemouton committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0faf32d View commit details
    Browse the repository at this point in the history
  4. BOLT 03: fix anchors same amt and pre-image test vector

    The `commitment tx with 3 htlc outputs, 2 offered having the same amount
    and preimage` test was not correctly updated after the value of test
    htlc 6 was changed to 5000001 and the cltv expiry of test htlc 5 was
    changed to 506. This commit updates the anchors test accordingly.
    ellemouton committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d8b8b1e View commit details
    Browse the repository at this point in the history