fix broken link

[antonilol]

again lol

[instagibbs]

these are honestly all over the place in my experience, any way we can lint these?

[antonilol]

i had some idea to list all links in the documents and all possible destinations and compare them (or something like this)

[antonilol]

this is about what i imagined, it does not work yet and has bugs
it prints every link that points to something not found in any markdown file (*.md)

[vincenzopalazzo]

I agree with the automatic check, but I disagree on the custom script, we should automate this process, and check with a Github action like this https://github.com/gaurav-nelson/github-action-markdown-link-check

We should ran this action periodically, maybe 1 time each month?

[antonilol]

I agree with the automatic check, but I disagree on the custom script, we should automate this process, and check with a Github action like this https://github.com/gaurav-nelson/github-action-markdown-link-check

oh lol i did not search before making the script, but anyway it was fun to make

We should ran this action periodically, maybe 1 time each month?

i would suggest with every pull request

[vincenzopalazzo]

i would suggest with every pull request

for sure, but also the url can be broken after X period of time, once the PR is landed (with valid URL) on the master

[antonilol]

i would suggest with every pull request

for sure, but also the url can be broken after X period of time, once the PR is landed (with valid URL) on the master

ok yeah, a bit of an edge case, but good to also check those. i set it to every month and every pull request now

[antonilol]

are actions disabled in this repo?

[instagibbs]

wow, there's a script for this already? :D glad I asked

[antonilol]

more people had issues with broken links before

[vincenzopalazzo]

I think that the PR need to be merged before, otherwise creating a fake PR that trigger the CI can put down the Github action.

I had an attack like these in one of my repo, while a go now github disable it

[antonilol]

ok i will merge it on my fork then to test it

testing it here: antonilol#1

[antonilol]

it did not catch the error...

[t-bast]

it did not catch the error...

Does that mean the CI script you included doesn't work? Or am I misunderstanding? Not sure whether we should accept that change or just fix this specific broken link.

[antonilol]

Does that mean the CI script you included doesn't work?

Yes. It reported no errors where there was at least one.
I will remove the commit that adds that CI script. We could try other link checkers and see if they do work. The link checker currently in this pr now recommends a different one in its readme.

[t-bast]

We could try other link checkers and see if they do work. The link checker currently in this pr now recommends a different one in its readme.

Let's try that in a separate PR to see if that works!

[t-bast]

Thanks!