-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encodings in gossip_queries #811
Comments
@bmancini55 Or can you add a |
@ariard, that's an interesting idea! From my understanding of the historical conversation there isn't much interest in supporting additional encodings. That said, I believe compression addresses two concerns:
The latter exists because BOLT7 requires sequential My hope is that if we allow resumption on the same block in #804, concern 2 goes away and encoding becomes more a preferential thing than an escape hatch. |
Add a tlv field in `init` to list supported compression algorithms. This compression will be used in several places, currently in extended gossip queries. Fixes #811
Add a tlv field in `init` to list supported compression algorithms. This compression will be used in several places, currently in extended gossip queries. Fixes #811
Add a tlv field in `init` to list supported compression algorithms. This compression will be used in several places, currently in extended gossip queries. Fixes #811
Add a tlv field in `init` to list supported compression algorithms. This compression will be used in several places, currently in extended gossip queries. Fixes #811
Add a tlv field in `init` to list supported compression algorithms. This compression will be used in several places, currently in extended gossip queries. Fixes #811
Add a tlv field in `init` to list supported compression algorithms. This compression will be used in several places, currently in extended gossip queries. Fixes #811
We removed zlib support in #981, thus fixing this issue. |
Currently the spec requires an implementation to support both raw and zlib deflate encodings for
short_channel_ids
inreply_channel_range
andquery_short_channel_ids
messages.There is discrepancy of the default encoding used when replying to a query with
reply_channel_range
message. It would be nice to have clarification surrounding when zlib deflate or raw encodings should be sent in reply to a query.A bigger request is that rust-lightning would like to not add a zlib dependency to the project. There is currently no way to signal support or lack thereof for zlib. It would be nice if a node could signal this support in Init. There is likely overlap with #804 depending on how reply sequencing is structured, so I wanted to raise this issue for discussions while that is being discussed.
The text was updated successfully, but these errors were encountered: