Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 2: chain_hash requirement for accept_channel? #453

Closed
matthias-g opened this issue Jul 20, 2018 · 1 comment
Closed

BOLT 2: chain_hash requirement for accept_channel? #453

matthias-g opened this issue Jul 20, 2018 · 1 comment

Comments

@matthias-g
Copy link

In 02-Peer-Protocol the specification says, under accept_channel -> Requirements -> The receiver:

if the chain_hash value, within the open_channel, message is set to a hash of a chain that is unknown to the receiver:
- MUST reject the channel.

To my understanding this should be a requirement for the open_channel message instead for the accept_channel message. The chain_hash value is not included in the accept_channel message and as the receiver of the accept_channel message is the sender of the open_channel message, this would be the same as the requirement for the open_channel message, that the sender

MUST ensure the chain_hash value identifies the chain it wishes to open the channel within.

@matthias-g matthias-g changed the title 02 - Peer Protocol: chain_hash requirement for accept_channel? BOLT 2: chain_hash requirement for accept_channel? Jul 20, 2018
@rustyrussell
Copy link
Collaborator

Good catch, yes, it's in the wrong place....

rustyrussell added a commit to rustyrussell/bolts that referenced this issue Jul 23, 2018
Reported-by: Matthias Grundmann @Mattias-G
Fixes: lightning#453
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell added a commit that referenced this issue Jul 26, 2018
Reported-by: Matthias Grundmann @Mattias-G
Fixes: #453
Signed-off-by: Rusty Russell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants