-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define blip-0032, DNSSEC proof querying over onion messages #32
Define blip-0032, DNSSEC proof querying over onion messages #32
Conversation
dfd60a9
to
9f108e4
Compare
9f108e4
to
7eb227a
Compare
I intend to merge it in a week or two if no objections/further feedback are raised. |
Sounds good, there are still question around the encoding of some of the fields, but we can merge a first version and update it with what makes the most sense when an implementation is ready. |
Oh shit right, I intended to rewrite this to not have the weird omrequest thing, I've now rewritten this and think its ready to go (but will squash the commits before landing). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small inconsistency with the feature name, otherwise it looks good to me.
ca3e516
to
af0b621
Compare
Squashed and fixed the typo: $ git diff-tree -U1 ca3e516 af0b621
diff --git a/blip-0032.md b/blip-0032.md
index bb7ecff..03782e0 100644
--- a/blip-0032.md
+++ b/blip-0032.md
@@ -35,3 +35,3 @@ Two new onion messages are defined, `dnssec_query` and `dnssec_proof`.
Nodes which accept and reply to `dnssec_query`-containing onion messages from any sender:
- * SHOULD set the `dns_query` feature flag in their `node_announcement`.
+ * SHOULD set the `dns_resolver` feature flag in their `node_announcement`. |
I intend to merge this next week unless there is further feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK af0b621
No description provided.