Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define blip-0032, DNSSEC proof querying over onion messages #32

Merged

Conversation

TheBlueMatt
Copy link
Contributor

No description provided.

blip-0002.md Show resolved Hide resolved
blip-0032.md Outdated Show resolved Hide resolved
blip-0032.md Outdated Show resolved Hide resolved
blip-0032.md Show resolved Hide resolved
blip-0032.md Show resolved Hide resolved
blip-0032.md Outdated Show resolved Hide resolved
@TheBlueMatt
Copy link
Contributor Author

I intend to merge it in a week or two if no objections/further feedback are raised.

@t-bast
Copy link
Contributor

t-bast commented May 29, 2024

Sounds good, there are still question around the encoding of some of the fields, but we can merge a first version and update it with what makes the most sense when an implementation is ready.

@TheBlueMatt
Copy link
Contributor Author

Oh shit right, I intended to rewrite this to not have the weird omrequest thing, I've now rewritten this and think its ready to go (but will squash the commits before landing).

Copy link
Contributor

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small inconsistency with the feature name, otherwise it looks good to me.

blip-0032.md Outdated Show resolved Hide resolved
@TheBlueMatt
Copy link
Contributor Author

Squashed and fixed the typo:

$ git diff-tree -U1 ca3e516 af0b621
diff --git a/blip-0032.md b/blip-0032.md
index bb7ecff..03782e0 100644
--- a/blip-0032.md
+++ b/blip-0032.md
@@ -35,3 +35,3 @@ Two new onion messages are defined, `dnssec_query` and `dnssec_proof`.
 Nodes which accept and reply to `dnssec_query`-containing onion messages from any sender:
- * SHOULD set the `dns_query` feature flag in their `node_announcement`.
+ * SHOULD set the `dns_resolver` feature flag in their `node_announcement`.

@TheBlueMatt
Copy link
Contributor Author

I intend to merge this next week unless there is further feedback.

Copy link
Contributor

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK af0b621

@TheBlueMatt TheBlueMatt merged commit e9edaa2 into lightning:master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants