Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move GoogleTagManager script rendering to a dedicated component #43

Merged
merged 1 commit into from
Nov 17, 2019
Merged

refactor: Move GoogleTagManager script rendering to a dedicated component #43

merged 1 commit into from
Nov 17, 2019

Conversation

CorneeSean
Copy link
Contributor

No description provided.

chodorowicz
chodorowicz approved these changes Nov 17, 2019
View reviewed changes
Copy link
Collaborator

@chodorowicz chodorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
Would be good to comment out or fix tests that are not passing and turn the tests on on CI during build.

@CorneeSean CorneeSean merged commit 8791e6a into master Nov 17, 2019
@CorneeSean
Copy link
Contributor Author

@chodorowicz I have created a separate issue for fixing the tests for CI purposes: #50

I have assigned myself to do it, but if you'd like to give it a go - feel free to take it :)

@CorneeSean CorneeSean deleted the refactor/move-gtm-script-to-a-component branch November 27, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chodorowicz chodorowicz chodorowicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CorneeSean @chodorowicz